Matthieu MOREL

Results 139 issues of Matthieu MOREL

While applying require-error on https://github.com/argoproj/argo-cd I have seen this pattern many times ```golang if !assert.NoError(t, err) { return } ``` I fixed require-error rule by replacing it with ```golang require.NoError(t,...

enhancement

Following the different exchanges about error compare, I believe testifylint shall be allowed to recommend the use of ErrorContains, ErrorEqual, ErrorIs and NotErrorIs. See https://github.com/Antonboom/testifylint/issues/47#issuecomment-2047862514 for more context I believe...

documentation

This is a partial fix for #138 It doesn't fix this situations ```go assert.Empty(t, errs) assert.Empty(t, err.String()) ```

There are many places where an assertion is done on `arr.Len()` an interface that `assert.Len()` supports See. https://github.com/search?q=language%3Ago+testify+%22.Len%28%29%22+path%3A_test.go&type=code For example ```go assert.Equal(t, 0, arr.Len()) assert.Equal(t, 1, arr.Len()) ``` Shall be...

enhancement

While applying float-compare on https://github.com/prometheus/prometheus/pull/14334/files#diff-7c1dfea5c568897587621510c04d322f908a8ed40751e592d63d2f8422b6a78dR5926 I had deactivate testifylint here because it suggest to use `InDelta` here but once applied there is an error saying ``` Parameters must be numerical...

false-positive

* support /:protobuf_java and //:protobuf_javalite with bzlmod * upgrade rules_java to 6.0.0 (in MODULE.bazel) * upgrade rules_jvm_external to 6.0.0 (in MODULE.bazel) * upgrade com.google.errorprone:error_prone_annotations to 2.18.0 (in MODULE.bazel) Signed-off-by: Matthieu...

inactive

## Which problem is this PR solving? - Related to #5815 ## Description of the changes - Pin Codeql actions versions ## How was this change tested? - ## Checklist...

changelog:ci