elixir-ctags icon indicating copy to clipboard operation
elixir-ctags copied to clipboard

Update ctags regexes

Open dreamtigers opened this issue 6 years ago • 2 comments

Hello. I'm currently working on the Elixir parser for universal-ctags, and took your project there as the base for my changes. I made the regexes more exhaustive (but not completely exhaustive), and wanted to share my changes to upstream.

In the commit messages you'll find detailed information about each change. Feel free to ask or discuss any change.

dreamtigers avatar Mar 03 '19 13:03 dreamtigers

@dreamtigers, thank you for working in this area. I want to write some comments as an expert in Universal-ctags.

If you(we) want to use this .ctags with Exuberant-ctags, you cannot use '#' as a comment starter. The notation is introduced in Universal-ctags.

If you want to use this .ctags only with Universal-ctags, I strongly recommend you to use

--kinddef-Elixir=n,name,description

option. See https://github.com/universal-ctags/ctags/blob/master/man/ctags-optlib.7.rst.in. The change 2a98125 doesn't fit to --kinddef-<LANG> option. It implies you try to capture different language objects with one kind. I recommend you to use different kinds for different language objects.

masatake avatar Mar 03 '19 13:03 masatake

Thank you for your time. I hadn't read this before doing the pull request in the universal-ctags repo. I will make the necessary changes in both repos and submit again.

Thanks for the review.

On Sun, Mar 3, 2019, 9:37 AM Masatake YAMATO [email protected] wrote:

@dreamtigers https://github.com/dreamtigers, thank you for working in this area. I want to write some comments as an expert in Universal-ctags.

If you(we) want to use this .ctags with Exuberant-ctags, you cannot use '#' as a comment starter. The notation is introduced in Universal-ctags.

If you want to use this .ctags only with Universal-ctags, I strongly recommend you to use

--kinddef-Elixir=n,name,description

option. See https://github.com/universal-ctags/ctags/blob/master/man/ctags-optlib.7.rst.in . The change 2a98125 https://github.com/mmorearty/elixir-ctags/commit/2a981256b32593db0364f691f94664ebbe18b39d doesn't fit to --kinddef-<LANG> option. It implies you try to capture different language objects with one kind. I recommend you to use different kinds for different language objects.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mmorearty/elixir-ctags/pull/8#issuecomment-469023636, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ0eljr3Kel48qa0Aedwp09ZFKA1yE31ks5vS9AHgaJpZM4ba_Dv .

dreamtigers avatar Mar 03 '19 15:03 dreamtigers