pavlov icon indicating copy to clipboard operation
pavlov copied to clipboard

Do not use commas to separate description names.

Open ErikAbele opened this issue 13 years ago • 1 comments

Since JsTestDriver does not allow commas in test names this 'quick-n-dirty' fix is required to allow Pavlov to work in a JsTestDriver environment.

Note: a more sensible approach would be to fix JsTestDriver to not place restrictions on test names but this seems to be way harder to fix.

ErikAbele avatar Feb 19 '12 14:02 ErikAbele

Hi Erik. Thanks for the pull request!

I'm curious though - what version of JsTestDriver (and what browsers/versions) are you using? Pavlov's own test suite uses JsTestDriver as well without this issue.

Perhaps there has been a recent breaking change to JsTestDriver? If so, I would recommend a change like this be implemented as a callback function which would allow overriding of name concatenation formatting instead of directly changing it in the source.

mmonteleone avatar Feb 20 '12 16:02 mmonteleone