Momtchil Momtchev comments

Results 372 comments of


                                            Momtchil Momtchev

(Typed)ThreadSafeFunction.Release() crashes renderer process on reload (& abort?)

Yes indeed they are static, it might have been the data then, I will try to revert to `ThreadSafeFunction` to check what was the problem with using a dynamic object...

`ThreadSafeFunction` should handle exceptions in async callbacks identical to Node itself

Here is what I did: Ideally, I want to be able to call this:

`ThreadSafeFunction` should handle exceptions in async callbacks identical to Node itself

No, I am impacted by this `throw` in which is not covered

`ThreadSafeFunction` should handle exceptions in async callbacks identical to Node itself

@mhdawson This is a problem because after [#36510](https://github.com/nodejs/node/pull/36510) the only possible fix is to leave the exception handling in `node-addon-api::Function::MakeCallback` to Node itself - which means that without it exceptions...

`ThreadSafeFunction` should handle exceptions in async callbacks identical to Node itself

In fact, I think that the fundamental problem is that #36510 is an API-breaking PR that requires a `NAPI_VERSION` bump - before this PR `napi_make_callback` left the exception handling to...

`ThreadSafeFunction` should handle exceptions in async callbacks identical to Node itself

If you can check for this flag while remaining backwards compatible, sure, this can be a solution. Still, it will be somewhat problematic for the end user (the module author)...

[snackager] correct output with package type: module

I even wonder if this should not be extended to all packages with `module: "*"` since this transform can have only negative consequences - but on the other side maybe...

The runtime does not package the babel helpers while snackager uses runtime-transform

I was able to narrow the problem to that fact that my module has `type: "module"` and I was able to reproduce the problem outside of snackager with raw webpack...

Using a dynamic `RStyle` in React 18 triggers a warning in the console

https://stackoverflow.com/questions/71720001/clean-way-for-a-component-to-support-both-react-17-and-react-18 I am still looking for a way to support both React 17 and React 18 style rendering in a proper manner. Until then, the warning should be ignored as...

Does not work in sharepoint online

Do you have any error messages?