minimal-mistakes icon indicating copy to clipboard operation
minimal-mistakes copied to clipboard

Published 20 hours ago • verified publisher icon mmistakes

scss `float: left` on `.feature__item--right .archive__item` causes problem with embedded svg

Open DE0CH opened this issue 1 year ago • 0 comments

What happened?

  • Minimal Mistakes version: 4.24.0
  • Ruby gem or remote theme version: 4.24.0
  • Jekyll version: 3.9.2
  • Git repository URL: https://github.com/sums-sta/sums
  • Hosted on GitHub Pages (if yes provide URL to site): https://sums-sta.github.io/sums
  • Operating system: Linux

Expected behavior

I embedded a svg using feature_row aligned to the right (specifically {% include feature_row id="signup_row" type="right" %}), but the svg is not properly aligned (see attached screenshot).

Screenshot 2022-12-29 at 14-40-02 SUMS

Using Firefox's devtools, I noticed that in the <div class="archive__item"> html element, there is a float:left in .feature__item--right .archive__item. Turning it off fixes the problem (see attached screenshot) and brings about the expected behavior.

Screenshot 2022-12-29 at 14-42-28 SUMS

Digging through some scss, I found out that it is controlled by line 346 in /_sass/minimal-mistakes/_archive.scss.

https://github.com/mmistakes/minimal-mistakes/blob/8a67ce8e41ec850f2d7c373aa47739b2abfee6f1/_sass/minimal-mistakes/_archive.scss#L346-L348

Removing these lines fixes the problem.

Aligning feature_row to the left also does not work properly. This seems to be controlled by line 305 in /_sass/minimal-mistakes/_archive.scss.

https://github.com/mmistakes/minimal-mistakes/blob/8a67ce8e41ec850f2d7c373aa47739b2abfee6f1/_sass/minimal-mistakes/_archive.scss#L305-L307

I also noticed that this is part of the fix for Algolia search link positioning (#1904), but I am not able to verify if this is actually needed for the fix because I don't really know how to use Algolia search. If anyone else could help me verify this, I would really appreciate it.

Steps to reproduce the behavior

This is a styling issue so there's not many steps to reproduce except just runing bundle exec jekyll serve.

Log:

$ bundle exec jekyll build --trace --verbose
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
  Logging at level: debug
Configuration file: /home/chend/sums-website2/_config.yml
      GitHub Pages: github-pages v227
      GitHub Pages: jekyll v3.9.2
             Theme: jekyll-theme-primer
      Theme source: /home/chend/.local/share/gem/ruby/3.0.0/gems/jekyll-theme-primer-0.6.0
         Requiring: jekyll-github-metadata
Dotenv not found. Skipping 
         Requiring: jekyll-seo-tag
         Requiring: jekyll-paginate
         Requiring: jekyll-sitemap
         Requiring: jekyll-gist
         Requiring: jekyll-feed
         Requiring: jemoji
         Requiring: jekyll-include-cache
         Requiring: jekyll-redirect-from
         Requiring: jekyll-coffeescript
         Requiring: jekyll-commonmark-ghpages
         Requiring: jekyll-github-metadata
         Requiring: jekyll-relative-links
         Requiring: jekyll-optional-front-matter
         Requiring: jekyll-readme-index
         Requiring: jekyll-default-layout
         Requiring: jekyll-titles-from-headings
         Requiring: jekyll-remote-theme
   GitHub Metadata: Initializing...
            Source: /home/chend/sums-website2
       Destination: /home/chend/sums-website2/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
             Theme: mmistakes/[email protected]
      Theme source: /tmp/jekyll-remote-theme-20221229-5535-fhe147
      Remote Theme: Using theme mmistakes/minimal-mistakes
      Remote Theme: Downloading https://codeload.github.com/mmistakes/minimal-mistakes/zip/4.24.0 to /tmp/jekyll-remote-theme-20221229-5535-7b11nb.zip
      Remote Theme: Unzipping /tmp/jekyll-remote-theme-20221229-5535-7b11nb.zip to /tmp/jekyll-remote-theme-20221229-5535-fhe147
       EntryFilter: excluded /Gemfile
       EntryFilter: excluded /Gemfile.lock
           Reading: _posts/2021-01-01-new-year.md
           Reading: _posts/2022-12-28-progress.md
        Generating: JekyllRedirectFrom::Generator finished in 0.003327903 seconds.
        Generating: JekyllOptionalFrontMatter::Generator finished in 0.000113721 seconds.
        Generating: JekyllReadmeIndex::Generator finished in 8.3365e-05 seconds.
        Generating: Jekyll::Paginate::Pagination finished in 0.000259797 seconds.
        Generating: Jekyll::JekyllSitemap finished in 0.000296609 seconds.
       Jekyll Feed: Generating feed for posts
        Generating: JekyllFeed::Generator finished in 0.000557599 seconds.
        Generating: JekyllRelativeLinks::Generator finished in 0.000109122 seconds.
        Generating: JekyllDefaultLayout::Generator finished in 0.000325328 seconds.
        Generating: JekyllTitlesFromHeadings::Generator finished in 2.1511e-05 seconds.
         Rendering: _posts/2021-01-01-new-year.md
  Pre-Render Hooks: _posts/2021-01-01-new-year.md
  Rendering Markup: _posts/2021-01-01-new-year.md
         Requiring: kramdown-parser-gfm
  Rendering Layout: _posts/2021-01-01-new-year.md
     Layout source: theme
         Rendering: _posts/2021-01-01-new-year.md/#excerpt
  Pre-Render Hooks: _posts/2021-01-01-new-year.md/#excerpt
  Rendering Markup: _posts/2021-01-01-new-year.md/#excerpt
   GitHub Metadata: Generating for SUMS-StA/sums
   GitHub Metadata: No GitHub API authentication could be found. Some fields may be missing or have incorrect data.
   GitHub Metadata: Calling @client.pages("SUMS-StA/sums", {})
Include cache miss: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
Include cache miss: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
Include cache miss: /home/chend/sums-website2/_includes/masthead.html
Include cache miss: /home/chend/sums-website2/_includes/footer.html
         Rendering: _posts/2022-12-28-progress.md
  Pre-Render Hooks: _posts/2022-12-28-progress.md
  Rendering Markup: _posts/2022-12-28-progress.md
  Rendering Layout: _posts/2022-12-28-progress.md
     Layout source: theme
         Rendering: _posts/2022-12-28-progress.md/#excerpt
  Pre-Render Hooks: _posts/2022-12-28-progress.md/#excerpt
  Rendering Markup: _posts/2022-12-28-progress.md/#excerpt
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
 Include cache hit: /home/chend/sums-website2/_includes/masthead.html
 Include cache hit: /home/chend/sums-website2/_includes/footer.html
         Rendering: _pages/404.md
  Pre-Render Hooks: _pages/404.md
  Rendering Markup: _pages/404.md
  Rendering Layout: _pages/404.md
     Layout source: theme
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
 Include cache hit: /home/chend/sums-website2/_includes/masthead.html
 Include cache hit: /home/chend/sums-website2/_includes/footer.html
         Rendering: _pages/about.md
  Pre-Render Hooks: _pages/about.md
  Rendering Markup: _pages/about.md
  Rendering Layout: _pages/about.md
     Layout source: theme
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
 Include cache hit: /home/chend/sums-website2/_includes/masthead.html
 Include cache hit: /home/chend/sums-website2/_includes/footer.html
         Rendering: _pages/category-archive.md
  Pre-Render Hooks: _pages/category-archive.md
  Rendering Markup: _pages/category-archive.md
  Rendering Layout: _pages/category-archive.md
     Layout source: theme
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
 Include cache hit: /home/chend/sums-website2/_includes/masthead.html
 Include cache hit: /home/chend/sums-website2/_includes/footer.html
         Rendering: _pages/committee.md
  Pre-Render Hooks: _pages/committee.md
  Rendering Markup: _pages/committee.md
  Rendering Layout: _pages/committee.md
     Layout source: theme
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
 Include cache hit: /home/chend/sums-website2/_includes/masthead.html
 Include cache hit: /home/chend/sums-website2/_includes/footer.html
         Rendering: _pages/fun-problems.md
  Pre-Render Hooks: _pages/fun-problems.md
  Rendering Markup: _pages/fun-problems.md
  Rendering Layout: _pages/fun-problems.md
     Layout source: theme
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
 Include cache hit: /home/chend/sums-website2/_includes/masthead.html
 Include cache hit: /home/chend/sums-website2/_includes/footer.html
         Rendering: index.html
  Pre-Render Hooks: index.html
  Rendering Liquid: index.html
  Rendering Markup: index.html
  Rendering Layout: index.html
     Layout source: theme
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
 Include cache hit: /home/chend/sums-website2/_includes/masthead.html
 Include cache hit: /home/chend/sums-website2/_includes/footer.html
         Rendering: _pages/posts.md
  Pre-Render Hooks: _pages/posts.md
  Rendering Markup: _pages/posts.md
  Rendering Layout: _pages/posts.md
     Layout source: theme
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
 Include cache hit: /home/chend/sums-website2/_includes/masthead.html
 Include cache hit: /home/chend/sums-website2/_includes/footer.html
         Rendering: _pages/suggestions.md
  Pre-Render Hooks: _pages/suggestions.md
  Rendering Markup: _pages/suggestions.md
  Rendering Layout: _pages/suggestions.md
     Layout source: theme
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
 Include cache hit: /home/chend/sums-website2/_includes/masthead.html
 Include cache hit: /home/chend/sums-website2/_includes/footer.html
         Rendering: _pages/tag-archive.md
  Pre-Render Hooks: _pages/tag-archive.md
  Rendering Markup: _pages/tag-archive.md
  Rendering Layout: _pages/tag-archive.md
     Layout source: theme
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/skip-links.html
 Include cache hit: /tmp/jekyll-remote-theme-20221229-5535-fhe147/_includes/browser-upgrade.html
 Include cache hit: /home/chend/sums-website2/_includes/masthead.html
 Include cache hit: /home/chend/sums-website2/_includes/footer.html
         Rendering: assets/css/main.scss
  Pre-Render Hooks: assets/css/main.scss
  Rendering Liquid: assets/css/main.scss
  Rendering Markup: assets/css/main.scss
         Rendering: assets/js/lunr/lunr-en.js
  Pre-Render Hooks: assets/js/lunr/lunr-en.js
  Rendering Liquid: assets/js/lunr/lunr-en.js
  Rendering Markup: assets/js/lunr/lunr-en.js
         Rendering: assets/js/lunr/lunr-gr.js
  Pre-Render Hooks: assets/js/lunr/lunr-gr.js
  Rendering Liquid: assets/js/lunr/lunr-gr.js
  Rendering Markup: assets/js/lunr/lunr-gr.js
         Rendering: assets/js/lunr/lunr-store.js
  Pre-Render Hooks: assets/js/lunr/lunr-store.js
  Rendering Liquid: assets/js/lunr/lunr-store.js
  Rendering Markup: assets/js/lunr/lunr-store.js
         Rendering: redirects.json
  Pre-Render Hooks: redirects.json
  Rendering Markup: redirects.json
  Rendering Layout: redirects.json
         Rendering: sitemap.xml
  Pre-Render Hooks: sitemap.xml
  Rendering Liquid: sitemap.xml
  Rendering Markup: sitemap.xml
  Rendering Layout: sitemap.xml
         Rendering: robots.txt
  Pre-Render Hooks: robots.txt
  Rendering Liquid: robots.txt
  Rendering Markup: robots.txt
  Rendering Layout: robots.txt
         Rendering: feed.xml
  Pre-Render Hooks: feed.xml
  Rendering Liquid: feed.xml
  Rendering Markup: feed.xml
  Rendering Layout: feed.xml
           Writing: /home/chend/sums-website2/_site/404.html
           Writing: /home/chend/sums-website2/_site/about/index.html
           Writing: /home/chend/sums-website2/_site/categories/index.html
           Writing: /home/chend/sums-website2/_site/committee/index.html
           Writing: /home/chend/sums-website2/_site/fun-problems/index.html
           Writing: /home/chend/sums-website2/_site/index.html
           Writing: /home/chend/sums-website2/_site/posts/index.html
           Writing: /home/chend/sums-website2/_site/suggestions/index.html
           Writing: /home/chend/sums-website2/_site/tags/index.html
           Writing: /home/chend/sums-website2/_site/assets/css/main.css
           Writing: /home/chend/sums-website2/_site/assets/js/lunr/lunr-en.js
           Writing: /home/chend/sums-website2/_site/assets/js/lunr/lunr-gr.js
           Writing: /home/chend/sums-website2/_site/assets/js/lunr/lunr-store.js
           Writing: /home/chend/sums-website2/_site/redirects.json
           Writing: /home/chend/sums-website2/_site/sitemap.xml
           Writing: /home/chend/sums-website2/_site/robots.txt
           Writing: /home/chend/sums-website2/_site/feed.xml
           Writing: /home/chend/sums-website2/_site/emails/new-year/index.html
           Writing: /home/chend/sums-website2/_site/emails/progress/index.html
                    done in 5.209 seconds.
 Auto-regeneration: disabled. Use --watch to enable.
      Remote Theme: Cleaning up /tmp/jekyll-remote-theme-20221229-5535-fhe147

Other

No response

DE0CH avatar Dec 29 '22 06:12 DE0CH