jekyll-theme-basically-basic icon indicating copy to clipboard operation
jekyll-theme-basically-basic copied to clipboard

Menu animation on page change doesn't feel smooth

Open ljcp opened this issue 7 years ago • 4 comments

when you navigate to another page example "About" the menu feels like it is closed too fast and without progressive transition

ljcp avatar Jul 05 '17 08:07 ljcp

I've noticed this as well, being an absolute beginner when it comes to programming/web design I have no idea how to fix this. In almost every other way I think this theme is fantastic. But it would be nice to learn/figure out/ hear some guidance about how to make that transition smooth.

Wigdo avatar Jun 08 '19 18:06 Wigdo

@wigdo The menu closes when it detects a click. That's why when you click a link that goes to another page it looks less smooth. This is because the page is loaded before the animation finishes.

I have no idea how you'd fix that. I'd think some JavaScript to wait before the animation finishes before loading the page that was clicked, but I'm no JavaScript expert.

If someone wants to submit a pull request to improve things I'm all for that. Just seeing how this has sat around for almost a year I wouldn't expect much.

mmistakes avatar Jun 08 '19 19:06 mmistakes

@mmistakes after manually installing the _data, _includes, and other such folders that you have made available for download in a comprehensive .zip file, the transitions were smoother to the point of being, to me eyes, perfect. Downloading the files via the ordinary ruby gem installation method I noticed jerkiness in that transition/animation but not otherwise. Again, fantastic theme, really loving it ~

Wigdo avatar Jun 09 '19 06:06 Wigdo

@Wigdo Could be a placebo effect. The ruby gem is identical to what is on GitHub and in the .zip file it produces.

mmistakes avatar Jun 10 '19 15:06 mmistakes