MikkTSpace

MikkTSpace copied to clipboard

Hello, I noticed that there seems to be a couple of off by one errors in the edge sorting code. The condition checks [here](https://github.com/mmikk/MikkTSpace/blob/3e895b49d05ea07e4c2133156cfa94369e19e409/mikktspace.c#L1524) and [here](https://github.com/mmikk/MikkTSpace/blob/3e895b49d05ea07e4c2133156cfa94369e19e409/mikktspace.c#L1540) need to be `

siler

Trivial fix to appease UBSan

2

This should provide no change in behaviour but calms [UBSan](https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html). The branch should (hopefully) be optimized away by any modern compiler.

mchudleigh

Add LICENSE file

1

Thanks for making your library open source. I'm looking to package it for Fedora, and its recommended that packages include a separate file which has the license text. The project...

nicholas-rh

Generated tangent has same direction as normal

3

Is it a fair expectation that generated tangents should be different for normals? Is there something I need to do to make it so? I needed tangents for anisotropic light...

tksuoran

I was studying the code and noticed that the `IndexListSlow` generation code didn't work as expected. The index being used to compare was never recorded and as such the index...

sciecode

Undefined behavior in QuickSort() and QuickSortEdges()

1

```C // Random t=uSeed&31; t=(uSeed(32-t)); ``` When `t` is `0` after `t=uSeed&31`, UBSAN says `runtime error: shift exponent 32 is too large for 32-bit type 'unsigned int'`

tksuoran