AHK-v2-script-converter icon indicating copy to clipboard operation
AHK-v2-script-converter copied to clipboard

Updates to QuickConvertorV2.ahk and to QuickConverterV2_scintilla.ahk

Open drposts opened this issue 1 year ago • 4 comments

Mike, Thanks for all you have done here.

I reformatted QuickConverterV2.ahk and QuickConverterV2_scintilla.ahk. I don't know if you will be interested in these files but they may help speed up future updates. Here is a brief list of what I changed:

CHANGES:

  1. I reformated the programs to an easy to read foldable structure and alphabetized the functions and the hotkeys
  2. I added headers to the program and moved pre-main code into those headers
  3. In VARIABLES: I modified and expanded the IniRead and IniWrite statements.
  4. Under HOTKEYS: I added an exit script hotkey (ESC) and label (MyExit) and added IniWrite statements to save the current configuration on exit.
  5. In MAIN PROGRAM: I added a switch case to deal with a command line option to input a file name

I HAVE 2 REQUESTS:

  1. I haven't found the place to add a reference to the exit function in your code. Can you do that for me?
  2. I also haven't figured out how to shut down the scintilla editor panes safely, this causes an error with my hotkey exit. Can you help?

MyQuickConvertorV2.ahk.TXT QuickConvertorV2_scintilla.ahk.TXT

drposts avatar Mar 03 '23 19:03 drposts

The QuickConverter script was not built by me, it was built by @dmtr99 , so I cannot advise about that

If you want to propose changes, the best way is to fork the repository to your own github account, and then push your changes to your own branch, and then start a Pull Request here, so that we can easilly see the changes to the code

mmikeww avatar Mar 07 '23 00:03 mmikeww

Seems ok, I Just changed the Requires section, as it failed to automatically start v2 on my system.

Please clearify what you mean with the exit function, quickconvertor does not exit when you close the window. You can exit the program with the menu, or with the tray menu. This way you can select text and use the hotkeys to convert them.

dmtr99 avatar Mar 22 '23 20:03 dmtr99

The scintilla editor is indeed experimental and does not seem to work properly. It was an attempt, but it has indeed many bugs when using it. If a better library comes available, we can use it.

dmtr99 avatar Mar 22 '23 20:03 dmtr99

I just added the saving of the position and size and v1 code. This improves the gui a lot, as the data is saved.

dmtr99 avatar Mar 24 '23 21:03 dmtr99