Matthew Michel

Results 7 comments of Matthew Michel

Under existing issues, I believe we should add the following note which was recently identified and is a regression from the previous release fixed in PR https://github.com/oneapi-src/oneDPL/pull/1413: Crashes or incorrect...

I have addressed the comments on this PR thus far. I do have a remaining question with regards to the header file format Mikhail brought up which I have asked...

I have removed this from the `2022.7.0` milestone. Based on some initial investigation, widespread performance benefit is not observed with this change. Benefit seems to be limited to instances with...

The following TODO is also listed in the implementation of `_ReverseCounter`: ``` // TODO: Temporary hotfix. Investigate the necessity of _ReverseCounter // Investigate potential user types convertible to integral //...

I don't see any issues within `group_utils.hpp` header, so once the header addition issues are resolved this PR LGTM.

Thinking about the design in more depth, I do not think these APIs should be implemented as free functions. Rather, I think they should be implemented as classes which overload...

This PR looks to be in good shape for me. However, I think the outstanding comments in https://github.com/oneapi-src/SYCLomatic-test/pull/619 need to be addressed, so we can have confidence in the implementation's...