phpcrawl icon indicating copy to clipboard operation
phpcrawl copied to clipboard

Update setWorkingDirectory

Open ritey opened this issue 10 years ago • 3 comments

Check the override is writeable not the default and call internally the new function not the old

ritey avatar Oct 05 '15 15:10 ritey

Hi david,

Thanks for contributing. My goal with this repo is to have a composer-installable version of phpcrawl. I would no like to start modifying the core of PHPCrawl, since we sould have to backport the changes each time the phpcrawl code is updated.

Maybe extending the PHPCrawler class would be a better solution for you. You could depend on this repo in your composer.json and add a new class extending th base one that modifies the behavior so that it suits your needs.

Cheers,

Maxime

mmerian avatar Oct 05 '15 16:10 mmerian

Hi Maxime,

Thanks, I agree improving the core would be ideal, if only it was moved into Git and actively developed. Seems like it's gone stale :(

Cheers

Dave

ritey avatar Oct 05 '15 16:10 ritey

As there have been no updates to the main project in 4 years I am making minor fixes/improvements on phpcrawl here: https://github.com/crispy-computing-machine/phpcrawl - Pull requests welcome