Michael Meeks
Michael Meeks
Rash - can we get this merged & closed or actioned in some useful way ? =)
@Rash419 I think we can safely say @genofire is not working on it. Can we come to a resolution here - finish & merge or close for now - either...
In general adding a new lock is a nightmare. We want to reduce the number of locks, and simplify interactions. Having a valid reason for having two locks to protect...
> As I wrote, I will split out the config and TimeAverage (~400 lines or so) and put the remainder at the bottom -> 3 commits within this pull request....
> Since I am quite happy now, I move this to 'review'. Thanks Sven - sounds very promising =) good stuff.
I'm confused. I still see some patches eg. this one: https://github.com/CollaboraOnline/online/pull/9916/commits/e5d6dc55a210aab1aa3d22b408e4726fbda96945 that has a combination of totally safe, new debugging methods, as well as much the more risky 'isClosed' change,...
Well - CI passes which is a good sign; I'm really not happy at having cosmetic cleanups merged with drastic functional change - today you can see where the functional...
> > I had a nightmare last night (literally) that the lifecycle of ClientSession is essentially owned by the SocketPoll (is it?) > > Sort of. So I did a...
Actually - I lie the c1,2,3,4 thing really needs fixing or explaining; its not clear to me that it will work =)
It would be good to cleanup the ordering functionality at the same time though eg. // FIXME: it's not that clear what good this does for us ... // we...