avo icon indicating copy to clipboard operation
avo copied to clipboard

tests/thirdparty: add probakowski/curve1174

Open mmcloughlin opened this issue 3 years ago • 2 comments

https://github.com/probakowski/curve1174

mmcloughlin avatar Apr 11 '22 05:04 mmcloughlin

@probakowski See #248 for a PR that adds your repository to the third-party compatibility test suite for avo. Unfortunately, the test failed in Github Actions with an illegal instruction exception. Usually this happens when some code isn't doing the right CPU feature checks.

I'd be grateful if you could take a look and give your assessment of what's going wrong. Thanks!

mmcloughlin avatar Apr 17 '22 05:04 mmcloughlin

@probakowski See #248 for a PR that adds your repository to the third-party compatibility test suite for avo. Unfortunately, the test failed in Github Actions with an illegal instruction exception. Usually this happens when some code isn't doing the right CPU feature checks.

I'd be grateful if you could take a look and give your assessment of what's going wrong. Thanks!

Chiming in from the peanut gallery, the assembly mulD and sqr use ADX and BMI2 unconditionally, with the CI test choking in the latter. So indeed this needs fallback code.

Yawning avatar May 02 '22 07:05 Yawning