Matt McKay

Results 784 comments of Matt McKay

thanks @raptistasos for opening this issue. Thanks @florianbussmann for the PR. I see @AakashGfude is now reviewing that.

hi @markusritschel I don't think is is an option for `jupyter-book`. It may not be too hard to support as a **feature request**: https://stackoverflow.com/questions/25583581/add-open-in-new-tab-links-in-sphinx-restructuredtext

just as part of this discussion - we've had some feedback on our projects that some users don't like this as default behaviour with a preference to open links in...

thanks @markusritschel -- that's a nice idea too. I think a user specified option to enable new tab for external links should be achievable. Thanks for the feedback and ideas....

hey @choldgraf and @AakashGfude can't we just test for `http` or `https` and apply to those links. From memory `sphinx` uses the following `html` structure for internal links ```html (39.8)...

@AakashGfude ok great. The link above provides a really simple approach to updating the `translator` ```python from sphinx.writers.html import HTMLTranslator class PatchedHTMLTranslator(HTMLTranslator): def visit_reference(self, node): if node.get('newtab') or not (node.get('target')...

I see this as a `myst_nb` addition or super simple extension. I view `jupyter-book` as a `cli`/`interface` to the executable books software stack.

> as external links opening in a new tab is a good default approach. I think this is up for debate :-). I think it should be an option (but...

👍 but let's call it `MySTNBHTMLTranslator` and other things can be added (as needed in the future)

hey @choldgraf not sure I follow fully. This should update the in-built `HTMLTranslator` to add a bit of logic around adding the `_black` for external links. The `builder` shouldn't change...