gofeed icon indicating copy to clipboard operation
gofeed copied to clipboard

Use of internal package makes working on a fork difficutl

Open ghost opened this issue 6 years ago • 1 comments

detector.go imports an internal package:

"github.com/mmcdole/gofeed/internal/shared"

This makes it difficult to build main in a fork:

$ pwd
/home/lutz/go/src/github.com/lutzhorn/gofeed
$ go build
detector.go:7:2: use of internal package github.com/mmcdole/gofeed/internal/shared not allowed

I suggest to rename internal so that building in a fork is possible.

ghost avatar Jan 30 '19 08:01 ghost

I see how this could be a pain. I also don't feel especially strongly about the internal package, but I do believe I'm using it as intended, following Go conventions. Most of the items in internal are not meant to be exported or part of the public API for the library.

Here is an answer of how to possibly work on a fork, from another project that has a similar structure:

https://stackoverflow.com/questions/46860546/go-use-of-internal-package-not-allowed-when-running-a-go-project-forked-fro

I'll leave the issue open for now, to see if others have suggestions.

mmcdole avatar Feb 02 '19 04:02 mmcdole