gofeed icon indicating copy to clipboard operation
gofeed copied to clipboard

Added custom user agent support on rss.Parser

Open GaruGaru opened this issue 5 years ago • 6 comments

Related to #74 Some feed such as reddit's rss feed provide a very low request rate for bots, it would be nice to have an easy to use way to set a user defined user agent for the parser

GaruGaru avatar Oct 24 '18 13:10 GaruGaru

Coverage Status

Coverage decreased (-0.001%) to 60.583% when pulling add64f6c0bae95fe12796292b9b452d90e2f6c90 on GaruGaru:master into eb870fd61fb89d07d55477e20d11449308489349 on mmcdole:master.

coveralls avatar Oct 24 '18 13:10 coveralls

Coverage Status

Coverage decreased (-0.001%) to 60.583% when pulling add64f6c0bae95fe12796292b9b452d90e2f6c90 on GaruGaru:master into eb870fd61fb89d07d55477e20d11449308489349 on mmcdole:master.

coveralls avatar Oct 24 '18 13:10 coveralls

Coverage Status

Coverage decreased (-0.001%) to 60.583% when pulling add64f6c0bae95fe12796292b9b452d90e2f6c90 on GaruGaru:master into eb870fd61fb89d07d55477e20d11449308489349 on mmcdole:master.

coveralls avatar Oct 24 '18 13:10 coveralls

@mmcdole Will this be merged? Is it because coverage cc @GaruGaru?

bogatuadrian avatar Mar 30 '19 21:03 bogatuadrian

I think it does not add much value: one can always use http to fetch and parse with fp.Parse. It's even a good idea to implement your own download function to handle network errors/retries/headers/etc better

OrKoN avatar Apr 11 '19 20:04 OrKoN

Would still love to have this option for when making quick prototypes and stuff.

lmas avatar May 14 '19 15:05 lmas