top-github icon indicating copy to clipboard operation
top-github copied to clipboard

[Feature Request] Open links from the repository in a webview inside the application

Open douglasaugusto opened this issue 8 years ago • 5 comments

Opening the repository links in the mobile device browser and then getting back to the application can be annoying, so I suggest opening the links in a webview of the application itself.

An example of the functionality, is the Facebook application itself.

I hope it is well explained, and in case you need help, I can build on the development of it.

douglasaugusto avatar Apr 23 '17 16:04 douglasaugusto

Hello @douglasaugusto, a PR would of course be appreciated 👍 The important bit here is that imho it should be an option in the setting, let me know what do you think about it.

Sorry for answering a bit late, I was on vacation.

mmazzarolo avatar Apr 26 '17 07:04 mmazzarolo

Hi @mmazzarolo

I agree that this may be an option to be selected, since some users may have Git Clients on their mobile phone and want to open it, for example, not inside the app itself.

Contact that the application still does not have a Settings tab, besides this option to open in or out of the application, do you think valid already leave open a color customization for the application?

If so, I can add this together in PR, and the settings tab gets more than one customization.

douglasaugusto avatar Apr 26 '17 17:04 douglasaugusto

Of course, it would be nice touch, but also keep in mind that many smaller PRs are easier to review than a massive one.
Do you already have any plan on how to implement the "Settings page" in the UI?

mmazzarolo avatar Apr 26 '17 18:04 mmazzarolo

I can try to separate the PRs in:

  • Creating the configuration
  • Creation of the color customization option within the settings
  • Creation of the mode of visualization of the links inside the settings

Regarding the location of the settings in the UI: I think it's cool for Navigation Drawer to remain alone with the selection of languages, so I thought the best place would be to place the icon more_vert on the Right side of the current period/calendar selection icon.

What do you think of this approach?

douglasaugusto avatar Apr 26 '17 18:04 douglasaugusto

I was thinking the same, 100% on point 👌

P.S.: I'll obviously mention you as a contributor/author both on the repo and on the Google Play Store as soon as the PRs land.

mmazzarolo avatar Apr 26 '17 18:04 mmazzarolo