react-native-universal-monorepo icon indicating copy to clipboard operation
react-native-universal-monorepo copied to clipboard

Published 20 hours ago • verified publisher icon mmazzarolo

Fix build/script script names in electron

Open whenmoon opened this issue 3 years ago • 5 comments

When I run yarn electron:package:mac I get the error "Command "build" not found". When I update the packages/electron package.json script to remove yarn build from the "package:mac" script, electron build throws the error: "Application entry file "build/electron.js in Contents/Resources/app.asar" does not exist".

Is there a way to resolve this? Thanks.

whenmoon avatar Dec 01 '21 21:12 whenmoon

Ok solved the latter issue by running the cra:build script first.

whenmoon avatar Dec 01 '21 22:12 whenmoon

Ha! @whenmoon this is actually a bug, good call — these two commands should probably drop the cra: prefix.

mmazzarolo avatar Dec 02 '21 07:12 mmazzarolo

Hi @mmazzarolo, ok , I'll open a PR to fix..

whenmoon avatar Dec 02 '21 13:12 whenmoon

Remove cra: prefix and then remevoe ^ at devDependencies of electron. like that ^14.0.0 -> 14.0.0

WayneKim92 avatar Mar 28 '22 16:03 WayneKim92

In my opinion, this issue can be closed.

code4break avatar May 30 '22 08:05 code4break