chrome-another-tab icon indicating copy to clipboard operation
chrome-another-tab copied to clipboard

Published 20 hours ago • verified publisher icon mmazzarolo

Add tooltip to the top right buttons

Open mmazzarolo opened this issue 6 years ago • 9 comments

Easy one, add a tooltip to the:

  • Show/hide hidden folders button
  • Change theme button

mmazzarolo avatar Jan 13 '19 14:01 mmazzarolo

Hi I'll do this if that's cool.

ngensimore avatar Jan 13 '19 17:01 ngensimore

Sure, feel free to send a PR and/or to ask for suggestions! Top right icons/buttons are all shown here and their style is defined here.

mmazzarolo avatar Jan 13 '19 17:01 mmazzarolo

@mmazzarolo Saw this was still open so went ahead and jumped on it, happy to push it up and open a PR.

ONeill45 avatar Feb 20 '19 19:02 ONeill45

@ONeill45 yes, absolutely, thanks! 👍 Please point to the develop branch. Let me know if you need any help.

mmazzarolo avatar Feb 21 '19 08:02 mmazzarolo

@mmazzarolo branched off of develop and it's giving me permission denied to push back up to the repo

ONeill45 avatar Feb 21 '19 16:02 ONeill45

You mean you can submit the PR?

mmazzarolo avatar Feb 21 '19 16:02 mmazzarolo

It won't let me push my branch up so I can create the PR

ONeill45 avatar Feb 21 '19 21:02 ONeill45

@ONeill45 you have to fork out to your own GitHub repo and then open PR from there :)

dkozickis avatar Feb 22 '19 08:02 dkozickis

@mmazzarolo ahh gotcha, used to opening a new branch not forking. I'll get the PR in today

ONeill45 avatar Feb 22 '19 19:02 ONeill45