fx and fy in IntrinsicsCamera are in pixel units?

[snavely]

The documentation of IntrinsicsCamera states that the fx and fy input parameters are in units of meters. However, it is difficult for me to understand what that means, since to understand focal length in meter units means that you also know the size of the sensor (or image plane) in meters as well... instead, it seems from my tests that fx and fy are actually meant to be specified in pixel units. Is that correct?

[mmatl]

Yes, that's correct! I'll update the docs soon.

[duanyongli]

@mmatl Thanks for your great work, and fx and fy input parameters are still in units of meters.

[johnwlambert]

Hi @mmatl, thanks for the great library.

It looks like @snavely's PR fixed the docstring but the docs still need to be updated or regenerated -- https://pyrender.readthedocs.io/en/latest/generated/pyrender.camera.IntrinsicsCamera.html