Michal Matczuk
Michal Matczuk
One thing to note is not to use the http2 conn if the handling with connection upgrade. https://github.com/kubernetes/kubernetes/pull/88781/files#diff-09ebe223122bee0cad4dde23b1c6b36ea2e30fe45e25ca4cd2e04b32a13948d6
Another thing to note is that this approach can be used to elegantly implement #99.
This requires logger API change to accept context.
Tests exist, we need to compile with -race flag. I suggest to add -race flag to update-devel-image in CI. Race flag requires cgo and cannot be used in cross-compilation.
The `-race` flag is added to dev image in #550.
Goproxy uses session `ctx.Session & 0xFF` as identifier we should probably adapt it ``` func (ctx *ProxyCtx) printf(msg string, argv ...interface{}) { ctx.Proxy.Logger.Printf("[%03d] "+msg+"\n", append([]interface{}{ctx.Session & 0xFF}, argv...)...) } ```...
There are exported logging functions ``` // Logf prints a message to the proxy's log. Should be used in a ProxyHttpServer's filter // This message will be printed only if...
I think its not needed since we log request with response.
Reopening the issue. This mainly requires changes in Marian logging, when sth goes wrong, we want to know which issue caused the error.