Matt Mastracci

Results 125 issues of Matt Mastracci

This is a first pass at `ARCHITECTURE.md`, a high-level overview of how `deno_core` works.

We don't have a good way to handle nullable objects for `cppgc` types. Ideally we'd automatically handle them via null handling in params and return values.

Ideally the re-entrancy guard should only protect the op call itself, not the surrounding error-handling code that is out of control of the op writer.

- [ ] Avoid serializing module globals for modules that won't be imported using `import "module"` syntax. These add extra overhead to the snapshot. We may be able to avoid...

We disabled support for typed buffers to fix #417. We may be able to restore this support by generating JS wrappers that extract the underlying ArrayBuffer and passing it, along...

ops
high priority

Valgrind reports that we're somehow depending on uninitialized values in v8's cppgc heap. Reproducible by running unit tests directly in valgrind. ``` ==3963== 160 errors in context 8 of 10:...

We occasionally need to make cppgc parameters optional -- this should be supported by the #[cppgc] object, mapping null/undefined to None.

We ended up including v8 snapshot flags that were ineffective, but v8 prints to the terminal without actually erroring. We need to ensure that stdout/stderr for a snapshot is correctly...

May be related to these issues. We need to add checkin integration tests that ensure that this doesn't happen. https://github.com/denoland/deno/issues/22144 https://github.com/denoland/deno/issues/22148