mary marchini
mary marchini
Oh nice, the GitHub part of this PR was rendered unnecessary by GitHub earlier this week: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/. With the new event announced in this blog post we can move everything...
I take it back, the new event is still not enough for some use cases (basically any use case that is not a check/linter/test), so we still want the relay
FYI I'll break this into two PRs: one for the Jenkins relay and one for the GitHub relay. Starting with the Jenkins relay which I think is more straightforward. This...
I'm just back from vacation and was planning on picking this up again in a few weeks :) If you have time before that, feel free to pick it up.
It could even update the webhooks on a given repository automatically: https://docs.github.com/en/rest/reference/repos#webhooks
Exactly. It would look like this: https://github.com/nodejs/node/pull/32116#issuecomment-597683266 Edit: I updated all Bot comments on https://github.com/nodejs/node/pull/32116 to also include the failures, if anyone wants to see how "the bot could edit...
I just thought of two other huge benefits of this: 1. We'll keep a history of CI failures (since Jenkins deletes old CI runs) 2. When searching for a flaky...
That might be a good idea. I also think the "edit comment" idea would be more likely to be well received. I'll start a poll, thank you for the suggestion.
FYI I'm trying the alternative approach on a personal repository with a local Jenkins instance. Proof of concept will be `comment on pr` -> `triggers Jenkins CI` -> `publish status`,...
My gut feeling is that if we can make everything work with actions, and we don't start hitting Actions limits all the time, it should be easier to maintain and...