Miles Malerba

Results 99 comments of Miles Malerba

@jelbourn Do you know if we want to change density of things in an overlay? I remember there being some discussion about not needing to do that, but also maybe...

I added an agenda item for our next meeting with them. Will mark this as blocked pending their feedback

This is actually done intentionally so that we're not constantly rendering new elements while the user is rapidly scrolling which would be detrimental to performance. However, there is probably some...

Thank you for taking time to provide this detailed and well thorough feedback! We really appreciate it, sorry that it took so long to respond. 1. This is something others...

Yeah changing the `instanceof` sounds reasonable to me. Just be sure to include a comment explaining why we're avoiding it. That's a pretty cool `TestElement` prototype. I'll file an FR...

The errors don't look trivial to resolve. Some of the tests seem to be intentionally verifying that elements are not refreshed. I think we'll need to discuss with someone on...

It seems really strange to me to call a method that sounds like its supposed to focus the element and instead it blurs it. Why not just default the origin...

I see it more as a version of the native `focus` method that allows the user to override the origin. I think just switching the implementation to the behavior you're...

@dariobraun I've rebased this for you and cleaned up some of the lint issues, but there's still failing tests on CI that will need to be fixed before this can...

Closing since this fix is for the legacy mat-form-field which has been superseded by the MDC based one.