Michael MacFadden

Results 56 comments of Michael MacFadden

I am also seeing this issue now. esdoc: v1.1.0 and the esdoc-typescript-plugin: v1.0.1.

The undo behavior will largely be added into Convergence itself, and then we will update this library if it needs changes to support that.

More insight, in the order function https://github.com/dagrejs/dagre/blob/7e050f82852c0d1b3c07b914f683d108fa28938b/lib/order/index.js#L29 When the initial `layering` matrix is created, the layers do not have undefined in them. https://github.com/dagrejs/dagre/blob/7e050f82852c0d1b3c07b914f683d108fa28938b/lib/order/index.js#L34 However later on on line 52 the...

Hi @j6k4m8, I am actually using the Directed Graph Layout from JointJS that uses Dagre. I am actually building a JointJS graph. JointJS is then building a GraphLib graph to...

Some more debugging. In one of the calls to this method: https://github.com/dagrejs/dagre/blob/7e050f82852c0d1b3c07b914f683d108fa28938b/lib/order/index.js#L43 Several elements in the layering array go from string values to undefined.

And finally... in this method: ```js function buildLayerMatrix(g) { var layering = _.map(_.range(maxRank(g) + 1), function() { return []; }); _.each(g.nodes(), function(v) { var node = g.node(v), rank = node.rank;...

So in terms of the graph, I don't think the nodes are undefined at all. What is happening is that there is a matrix called `layering` that is used to...

I will have to try that. I have been working on isolating the problem in the source data. I know for example if I take all the edges out of...

Looking here: https://github.com/dagrejs/dagre/blob/7e050f82852c0d1b3c07b914f683d108fa28938b/lib/rank/index.js#L29 the rank method states that as a post condition: ``` * Post-conditions: * * 1. Graph nodes will have a "rank" attribute based on the results of...

More information.. Prior to calling the nestedGraph method https://github.com/dagrejs/dagre/blob/7e050f82852c0d1b3c07b914f683d108fa28938b/lib/layout.js#L34 All the nodes in the graph look something like this: ```JS { "0b7c8847-5ad5-4115-b7a0-cee55295a23c": {width: 300, height: 300} "0b50f2ad-7697-4392-8a5d-9a2744b9deaa": {width: 300, height:...