Catting

Results 121 comments of Catting

Current TODOs: - Move post parent removal from post model to (post controller? not sure here) since it doesn't pertain to an individual post - Write tests for post parent...

Another consideration for adding to this, since it has to do with pools: add a field for adding a source to all posts this applies to.

oops, i messed up my squashing

Okie I think i fixed it... my bad

Alright sorry for the mess of a PR

Both of these are good ways to do this, but just using another set characters that is already disallowed in tag names or something would entirely bypass any issues with...

> grouping with anything but parenthesis will be extremely unintuitive so is using `~` as the or operator imo.

> What do you propose we group with? Percent signs? None of the characters that aren't allowed in tags are good for grouping things together > > https://github.com/e621ng/e621ng/blob/9b8344d943d5c81047800982dae12e79414950ea/app/logical/tag_name_validator.rb#L7-L18 I actually...

OK, so here is what I am seeing what the code does: The `query_string` from the search enters `ElasticPostQueryBuilder` -- (eg "A -B ~C ~D") TagQuery is called with `query_string`...