Marcin M

Results 7 comments of Marcin M

LGTM - but please revert the change in contracts (the code should work without it, right?)

i see that in this pr you are simply copying binaries from docker to others. my original idea was to mount this docker as a volume in our docker compose...

is there any reason for this? Every struct that is serializable, makes it harder to do breaking changes to (for example, if I'm adding or removing the field, now i...

@haraldh - what do you mean by 'public constructor'? AFAIK in rust as long as all the fields are pub, you have implicit public constructor (Struct{field1: xx, field2: yy} )

@haraldh - what do you mean by 'shadow structs'? and do you actually serialize these objects as strings?