torchvision icon indicating copy to clipboard operation
torchvision copied to clipboard

support for more datasets?

Open tdhock opened this issue 1 year ago • 4 comments

Hi! I see that R torch support mnist and cifar data sets, but I was wondering if there are plans to support the other data sets which are present in pytorch? https://pytorch.org/vision/stable/datasets.html

tdhock avatar Feb 05 '24 17:02 tdhock

Hello @tdhock,

Which one should be a priority for you ?

Don't you want to try to do it on your own and propose a pull-request? Depending on which dataset, you may need to simply augment dataset-mnist.R or dataset_cifar.R or take inspiration out of both files.

cregouby avatar Aug 31 '24 12:08 cregouby

all of them would be great but perhaps it would be easiest to start with the mnist variants? I expected that the R package would provide the same/analogous functionality as the python module. More generally, is there documentation for what features of the python version are not implemented? And which will be implemented at some point? And which will never be implemented?

tdhock avatar Sep 01 '24 00:09 tdhock

Hello @tdhock

MNist variant are indeed a good first issue to try: you have to duplicate the block of code https://github.com/mlverse/torchvision/blob/6310e2e840ea2305d772de269970b3cb5953e52d/R/dataset-mnist.R#L122-L150 and modify the few varables name, ressources and classes . Do you want to give a try ?

For the difference in between implementations, there is not such thing AFAIK. And there is no implementation plan nor a plan to "never implement", but only your and the community spare time to contribute...

cregouby avatar Sep 01 '24 09:09 cregouby

I don't have time myself but it sounds like a reasonable target for a gsoc'25 contributor, I wrote a project, https://github.com/rstats-gsoc/gsoc2025/wiki/torch-in-R-improvements could you co-mentor next summer? If so could you please add your name/email under EVALUATING MENTOR on that wiki page?
are there any other tasks where someone could contribute? If so please add them to "Details of your coding project"

tdhock avatar Sep 02 '24 01:09 tdhock