torch icon indicating copy to clipboard operation
torch copied to clipboard

Maybe remove calls to `set.seed` and `torch_manual_seed()` from the tests

Open sebffischer opened this issue 11 months ago • 2 comments

If we set the seeds in the tests, everything afterwards is deterministic. For some tests that randomly generate data, it would maybe be better to have them be executed randomly to increase the test coverage.

sebffischer avatar Jan 16 '25 06:01 sebffischer

This will be a significant amount of work to implement given how it currently expects.

dfalbel avatar Jan 16 '25 17:01 dfalbel

What I mean with the issue is that one could instead using something like with_torch_local_seed(...) to make the subsequent tests not deterministic.

sebffischer avatar Jan 20 '25 06:01 sebffischer