spheretree icon indicating copy to clipboard operation
spheretree copied to clipboard

Fix code scanning alert no. 1: Potentially unsafe call to strncat

Open mlund opened this issue 1 year ago • 0 comments

Fixes https://github.com/mlund/spheretree/security/code-scanning/1

To fix the problem, we need to ensure that the strncat function uses the remaining space in the destination buffer. This can be done by subtracting the current length of the destination string from the total buffer size and then subtracting one more to account for the null terminator.

  • Update the strncat call to use the remaining space in the buffer.
  • Specifically, change the third argument of strncat to sizeof(qh_qhull_command) - strlen(qh_qhull_command) - 1.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

mlund avatar Oct 23 '24 07:10 mlund