moonrunner icon indicating copy to clipboard operation
moonrunner copied to clipboard

Published 20 hours ago • verified publisher icon mluedke2

Location simulation

Open adamhrz opened this issue 10 years ago • 1 comments

adamhrz avatar Feb 03 '15 16:02 adamhrz

Hi @adamhrz ! Thanks for the PR! I'm really excited to update this project with WatchKit. A few comments:

  • When I try to Build, Xcode notifies me that 1.25mileSampleGPS.json is missing. Could you either include the file or remove the dependency?
  • The matt-buckley.png image files snuck in, please remove :]
  • I noticed that the location manager is named WJRLocationManager-- for consistency could you remove the prefix?
  • There is some commented-out code in RunNotifier.m that should be removed
  • Raizlabs is great :] but I don't want to change the BundleIDs to com.raizlabs

I may have more comments after this round of edits. Thanks again for contributing!

mluedke2 avatar Mar 01 '15 23:03 mluedke2