mltframework
Draft: Initial work on OpenFX module support
Since I reached presentable state I published this change so I can receive feedback from the community.
This video shows testing the module with the uk.co.thefoundry.OfxInvertExample openfx sample plugin:
https://github.com/user-attachments/assets/86a4e68b-0287-4d7b-8fb9-4ae95102dd36
Yes this implementation still lack many things such as opengl, draw suit (which is something the plugins could use for drawing vector graphics like post script or cairo), multi-threading, openfx logging extension and still many things ignored and implemented as dummy functions.
Also this is still under testing it crashes for my many times.
I will require that you fix some bugs before you can submit new features. It is not fair to other developers if a person only does the more fun work of features but never helps fixing bugs.
I will require that you fix some bugs before you can submit new features. It is not fair to other developers if a person only does the more fun work of features but never helps fixing bugs.
That's fair. you have some bugs in mind? is it something related to my module (lv2, vst2) or in general?
JFYI, that if/when this feature is merged the https://www.mltframework.org/changes/todo/ will need to be updated. OpenFX is in the 'Old Roadmap'
JFYI, that if/when this feature is merged the https://www.mltframework.org/changes/todo/ will need to be updated. OpenFX is in the 'Old Roadmap'
Thank you for your curiosity.
Yes, I stopped working on this because of my personal situation I will do my best to get back working on this.
Just want to address the elephant in the room, ... where did you get the OpenFX headers? Just want this to be clarified so then its upstream is pulled for changes.
From the official source:
https://github.com/AcademySoftwareFoundation/openfx
The license notice on every header refer to that also
I want to close this PR because whenever you push to your branch, I am getting email notifications. Please wait until you are ready for review to open a new PR.
@ddennedy but what if OP is utilizing the CIs for orientation and fixes as well ? If OP set this as draft would that be a workaround ?
JFYI, that if/when this feature is merged the https://www.mltframework.org/changes/todo/ will need to be updated. OpenFX is in the 'Old Roadmap'
Note: kdenlive also points to this ticket as part of a Long Term Roadmap entry https://kdenlive.org/roadmap/#long-term
@joinlaw @mr.fantastic is there a place you're coordinating this (now that the PR has been closed) ? Besides https://github.com/mltframework/mlt/compare/master...joinlaw:mlt:openfx ?
@joinlaw @mr.fantastic is there a place you're coordinating this (now that the PR has been closed) ? Besides master...joinlaw:mlt:openfx ?
Yeah there is no other place. Anyway the code is more mature now and many plugins that didn't run before now running and I tested changing options from kdenlive and It works fine for comboboxes, sliders, and color buttons. More progress will happen when I'm free.
@joinlaw perhaps you can post on the kdenlive subforum ? https://discuss.kde.org/tag/kdenlive
cc @j-b-m @balooii @xwg2 (just putting this on your radar)
Why was this closed?
https://github.com/mltframework/mlt/pull/1051#issuecomment-3225504774
When OP has a working version they plan to make a new PR
Edit: in the meantime you can follow their work on their branch https://github.com/joinlaw/mlt/tree/openfx