mlrMBO icon indicating copy to clipboard operation
mlrMBO copied to clipboard

merge noisy multicrit stuff in

Open berndbischl opened this issue 7 years ago • 5 comments

please provide a PR. not every method must be in there. but at least the most important stuff.

berndbischl avatar Mar 23 '17 10:03 berndbischl

Not sure if I want to.

Reason: A bit of the stuff is "hacked code". If we add Noisy support, I would like to do it in a proper way. And for that, we first should extend ParamHelper. An Opt.Path should now if he is noisy, and there are some special getter-functions needed for the noisy case.

danielhorn avatar Mar 23 '17 10:03 danielhorn

Not sure if I want to.

well, how is our paper then reproducible? do you want to withdraw this? i mean nobody has access to it now. and the algorithms are not very complex we use

berndbischl avatar Mar 23 '17 10:03 berndbischl

i mean you are now running competitions with it. a bit strange if the code is not accessible....

berndbischl avatar Mar 23 '17 10:03 berndbischl

I would like to do it in a proper way.

sure. lets do it properly. i did not mean: merge it in without changes.

And for that, we first should extend ParamHelper. An Opt.Path should now if he is noisy, and there are some special getter-functions needed for the noisy case.

please open the corect issues in PH?

berndbischl avatar Mar 23 '17 10:03 berndbischl

Ok, to formulate it better: I want to publish and merge it - but I do not want to merge the current state of the code.

I will open an PH issue

danielhorn avatar Mar 23 '17 11:03 danielhorn