mlr3torch icon indicating copy to clipboard operation
mlr3torch copied to clipboard

Input checking must be done before entering the private `.train`

Open sebffischer opened this issue 1 year ago • 1 comments

mlr3torch would benefit from some additional input checks (e.g. whether the lazy tensor shape works with a specific learner), for that the mlr3::assert_task_learner() method would have to call the learner's input verification method.

The idea is, that such inconsistencies should not trigger a fallback learner, because it is a user error.

sebffischer avatar Jan 09 '24 12:01 sebffischer

Related PR: https://github.com/mlr-org/mlr3/pull/996

sebffischer avatar Jan 30 '24 08:01 sebffischer

THis is a larger operation in mlr3, we can do it once it is solved there. closing for now

sebffischer avatar Jun 13 '24 14:06 sebffischer