mlr3proba icon indicating copy to clipboard operation
mlr3proba copied to clipboard

added-ICI-measure

Open Lee-xli opened this issue 6 months ago • 3 comments

Hi mlr3proba team:

Just a couple of notes and thoughts (My apologies that I realised these after committing/pushing the document):

  • Line 30: pred = t(prediction$distr$cdf(tm))

I noticed that using pred = t(1 - prediction$distr$survival(tm)) will yield same results. The $survival prediction is perhaps preferred.

  • ICI plots:

I'm not sure if this is the right place to generate these plots. At the moment, I'm unable to add a proper title. The code generates the plots but terminates with an error. It worked for me for the time being, but it may be argued that these plots are not necessary for benchmarking comparisons, and thus should be made available only in a more general setting.

Thank you!

Lee-xli avatar Sep 02 '24 13:09 Lee-xli