mlr3pipelines icon indicating copy to clipboard operation
mlr3pipelines copied to clipboard

Small `pca` doc mistake

Open bblodfon opened this issue 2 years ago • 4 comments

Default value for pca center parameter is TRUE, not FALSE:

library(mlr3verse)
#> Loading required package: mlr3
pca = po('pca')
pca$param_set
#> <ParamSet:pca>
#>                id    class lower upper nlevels       default value
#> 1:         center ParamLgl    NA    NA       2          TRUE      
#> 2:         scale. ParamLgl    NA    NA       2         FALSE      
#> 3:          rank. ParamInt     1   Inf     Inf                    
#> 4: affect_columns ParamUty    NA    NA     Inf <Selector[1]>

Created on 2022-06-22 by the reprex package (v2.0.1)

bblodfon avatar Jun 22 '22 12:06 bblodfon

Also I somehow can't view any "Construction" code on the website, e.g. this is a blank grey box, but can copy the code!

bblodfon avatar Jun 22 '22 12:06 bblodfon

thanks! I will look into what is breaking the pkgdown pages...

mb706 avatar Jun 23 '22 09:06 mb706

PCA issue fixed in 9e6b03c38807c9657597fbb03d1f8fb687a48b28. The pkgdown issue is more general so probably you would want to put it someplace else?

bblodfon avatar Jul 29 '22 11:07 bblodfon

I'm keeping this issue open as a reminder, I hope I get around to fixing this the next week.

mb706 avatar Jul 29 '22 11:07 mb706