mlr3learners icon indicating copy to clipboard operation
mlr3learners copied to clipboard

Rename "custom mlr3 defaults"

Open sebffischer opened this issue 1 year ago • 1 comments

I think it is bad that we call the section "custom mlr3 defaults". I think we should call it "Initial parameter values". Consider the example below

l = lrn("regr.rpart")
l$param_set$values = list()

Our "custom mlr3 defaults" are now gone, i.e. the are no defaults but initial values.

Happy to make a PR if we agree on this.

This has to be changed in:

  • [x] mlr3 - https://github.com/mlr-org/mlr3/pull/856
  • [x] mlr3learners - https://github.com/mlr-org/mlr3learners/pull/253
  • [x] mlr3extralearners - https://github.com/mlr-org/mlr3extralearners/pull/238
  • [ ] Explain the difference between defaults and initial values in the mlr3 docu / book

sebffischer avatar Sep 08 '22 12:09 sebffischer

@be-marc @mllg

sebffischer avatar Sep 08 '22 12:09 sebffischer