mlr3book icon indicating copy to clipboard operation
mlr3book copied to clipboard

Netflify PR preview

Open pat-s opened this issue 2 years ago • 5 comments

fix #411

  • Netlify cannot install R, hence we need the contents of the _freeze folder
  • Netflify must install quarto via a plugin

Source: https://quarto.org/docs/publishing/netlify.html#rendering-on-netlify

pat-s avatar Sep 15 '22 16:09 pat-s

Blocked by https://github.com/quarto-dev/netlify-plugin-quarto/issues/2.

pat-s avatar Sep 15 '22 17:09 pat-s

I see how building via quarto on netlify seems to be the more idiomatic approach, but wouldn't it suffice to do the same as for a bookdown book, where the book is rendered on GitHub Actions and the output folder is pushed to netlify?
See e.g. here https://github.com/EmilHvitfeldt/bookdown-github-actions-netlify/blob/master/.github/workflows/bookdown.yaml

jemus42 avatar Sep 21 '22 08:09 jemus42

Maybe, but I am not sure it will work. The linked repo only uses it to publish the final site and not as a preview proxy for PRs. I am not sure if this approach will work for the latter as I don't see any dynamic logic for PRs there. I'll check.

pat-s avatar Sep 25 '22 14:09 pat-s

No worries, I just had "I know I saw people have PR previews for bookdown..." in the back of my head - probably based on this writeup.

If it ends up being too fiddly though I don't want to belabour the point :)

jemus42 avatar Sep 25 '22 14:09 jemus42

Thanks, always good to ask and provide resources!

No worries, I just had "I know I saw people have PR previews for bookdown..." in the back of my head - probably based on this writeup.

In general netlify is nothing new, we had it already for the old website and blog. Yet nobody carried it over when the old one was replaced by the new mlr3website repo (as nobody seemed to care about previews), the same applies for the book and the gallery. Good to see some interest in this!

pat-s avatar Sep 25 '22 15:09 pat-s

Solved by #477

be-marc avatar Nov 21 '22 18:11 be-marc