mlr3book
mlr3book copied to clipboard
mlr-org
feat: add section about Filter-based feature selection
- Fixes a typo
- Adds brief section about how to do filter-based feature selection
TODO: ~~* [ ] Mention filter-based feature selection in the previous sections that list the different methods~~ (is already mentioned)
I don't think we should mention the caching, because afaik we don't cache intermediate results in pipelines. The other things you suggest are partly already mentioned in the intro. In general I do not want to overdo it here, because it is a tutorial on usage. Also I don't think we need mention ensemble filters in the mlr3 book if they are not avilable.
I don't think we should mention the caching, because afaik we don't cache intermediate results in pipelines. The other things you suggest are partly already mentioned in the intro. In general I do not want to overdo it here, because it is a tutorial on usage. Also I don't think we need mention ensemble filters in the mlr3 book if they are not avilable.
This sounds like you don't really want to change anything substantial.
I don't think we should mention the caching, because afaik we don't cache intermediate results in pipelines.
Apparently we don't have it yet in mlr3pipelines (https://github.com/mlr-org/mlr3pipelines/issues/16) which is somewhat of a pity as it is very important for filters. This is one of the large benefits using filters over wrappers. AFAIR I didn't implement the same logic back as in {mlr} because we wanted to do it in pipelines but eventually this will never happen.
The other things you suggest are partly already mentioned in the intro.
This is quite general reply. I wouldn't have raised them if my feeling was they are appropriately covered.
In general I do not want to overdo it here, because it is a tutorial on usage.
Sorry to be frank here but this sounds like an excuse for low motivation against medium complicated change requests to me ;)
Also I don't think we need mention ensemble filters in the mlr3 book if they are not avilable.
The belong to the topic and are available in {mlr}, hence one sentence about them (whether they exist and/or why not) is certainly of interest to the reader.
I stand with my opinion that important information/content is missing or should be restructured and would not be happy seeing this getting merged in it's current form. If you do, I might want to rewrite it afterwards.
Please don't get this wrong, it's great we finally get a section about filters (and I could have done so earlier!) but if we have one, I'd like to see it being high quality and rather spent a bit more time on it.
We discussed this a little today, and it was suggested to move the feature selection out of the optimization chapter.
@sebffischer @be-marc how does this PR fit in with https://github.com/mlr-org/mlr3book/pull/412 ?
@sebffischer @be-marc how does this PR fit in with #412 ?
Thanks for the reminder. I moved the section into the chapter feature-selection. I guess the part is not perfect but now Marvin will rework this chaüter. Maybe we should just merge it and he can decide which parts to keep and what not?