ParamHelpers icon indicating copy to clipboard operation
ParamHelpers copied to clipboard

expressions in makeParam, convertToCall

Open berndbischl opened this issue 7 years ago • 2 comments

for "requires" slot we run convertExpressionsToCall, for

len, lower, upper, values, default

we dont do that

that seems at least suspicous?

berndbischl avatar Jan 05 '17 13:01 berndbischl

because those you mentioned are treated by evaluateParamExpressions() whereas requires is treated by isFeasible().

jakob-r avatar Jan 05 '17 13:01 jakob-r

thats really not a good answer IMHO? isnt this the case (for requires):

  • a user can pass in quote or expression constructs. now we either have a "call" or "expression" object
  • but we want type safety in the constructed Param object, for the slot, so we autoconvert this, in this case always to a call

what i am asking is: if this is true, and the conversion then certainly is reasonable, the same argument holds for "len", "lower" and so on?

@mllg

berndbischl avatar Jan 05 '17 13:01 berndbischl