DeepLearning_Financial icon indicating copy to clipboard operation
DeepLearning_Financial copied to clipboard

pretty sure the results in the paper are because WT leaks future info

Open JannyKul opened this issue 6 years ago • 4 comments

I tried implementing this too. 99% certain their implementation has the Wavelet transform leaking info. If you just do LSTM on daily close_price your odds are slightly better than a coin toss, adding WT they jump to around 65%. Running WT by windows so you don't leak info probability drops below 50%. SAE isn't going to recover anything from that.

I kinda elaborated a bit here

would love to hear your thoughts

JannyKul avatar Feb 26 '19 18:02 JannyKul

@JannyKul See the following thread/issue (relevant): https://github.com/VivekPa/AIAlpha/issues/13#issuecomment-465045296

I am attempting to avoid this particular issue with the WT by applying it separately to a train-validate-test split as defined in the source article (Bao et al. 2017).

EDIT: I have read your medium article - I am skeptical of the results also, but that is also part of why I am attempting to replicate the results of the paper myself, first hand.

timothyyu avatar Mar 01 '19 00:03 timothyyu

Example of scaling and applying the wavelet transform to the train-validate-test split independently: image https://github.com/timothyyu/wsae-lstm/issues/7#issuecomment-468628367

timothyyu avatar Mar 01 '19 12:03 timothyyu

Hey guys, thanks for your comments. I totally agree that the paper most likely used the WT on the entire time-series. It should of course be done in a rolling fashion in which case even generating any profitable returns becomes very difficult. The approach might work on higher frequency data, but on those daily returns there is no chance that this approach works.

mlpanda avatar Mar 03 '19 12:03 mlpanda

@mlpanda agree entirely

JannyKul avatar Mar 13 '19 17:03 JannyKul