models icon indicating copy to clipboard operation
models copied to clipboard

Added Convert Function as discussed on Issue#22

Open heisenbuug opened this issue 4 years ago • 5 comments

Issue link

Added a new folder dataset_utils and currently the convert function can convert

  • csv -> json
  • csv -> xml

heisenbuug avatar Aug 24 '20 09:08 heisenbuug

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

  • All code should follow the style guide
  • Documentation added for any new functionality
  • Tests added for any new functionality
  • Tests that are added follow the testing guide
  • Headers and license information added to the top of any new code files
  • HISTORY.md updated if the changes are big or user-facing
  • All CI checks should be passing

Thank you again for your contributions! :+1:

mlpack-bot[bot] avatar Aug 24 '20 09:08 mlpack-bot[bot]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! :+1:

mlpack-bot[bot] avatar Oct 30 '20 08:10 mlpack-bot[bot]

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

  • All code should follow the style guide
  • Documentation added for any new functionality
  • Tests added for any new functionality
  • Tests that are added follow the testing guide
  • Headers and license information added to the top of any new code files
  • HISTORY.md updated if the changes are big or user-facing
  • All CI checks should be passing

Thank you again for your contributions! :+1:

mlpack-bot[bot] avatar Mar 21 '21 05:03 mlpack-bot[bot]

Hey @kartikdutt18, I will add json. xml -> csv by the end of today or tomorrow... I will also keep in mind the edits you suggested in here...

heisenbuug avatar Mar 22 '21 07:03 heisenbuug

Hey @kartikdutt18, I noticed something... If you go to the example here to see how the convert function works you can see that we gave an input .csv file with 10 rows and we got 1 XML file per row as output making total to 10 .xml files as output, is this right? Or do we also want an option to put all these in the same .xml file?

Shouldn't we have to put all of them in 1 file?

Also, we are planning to reduce boost dependencies, right? So should we use boost here?

heisenbuug avatar Mar 24 '21 12:03 heisenbuug