examples icon indicating copy to clipboard operation
examples copied to clipboard

GANs mnist

Open swaingotnochill opened this issue 3 years ago • 14 comments

@kartikdutt18 @zoq I have created this new pull request coz in the earlier branch a lot of stuff has been messed up. To do:

  1. Document Model architecture( It's half done).
  2. Notebook to create samples( but this can be done after we train the model).

Please check the correctness of script, especially the Evaluate Function and model save method. @zoq If this training file is correct, can you please train the model? Right now, the model will on 657 cycles with 1 epoch per cycle. May be we can improve on this? Your thoughts.

P.S: Ignore the file path, and make file configurations, I will fix them later on.

swaingotnochill avatar Jul 25 '21 13:07 swaingotnochill

@zoq @kartikdutt18 I forgot to mention that the split function is not working for me. Like it doesn't do anything, and the entire dataset is loaded. Can you check if it is the same for you?

swaingotnochill avatar Jul 27 '21 13:07 swaingotnochill

@swaingotnochill @Davidportlouis I just realized that we have a notebook that shows how you can load images into an armadillo matrix with the format mlpack expects - https://github.com/mlpack/examples/blob/master/cifar10_transformation_with_pca/cifar-10-pca-cpp.ipynb. Let me know if you have any questions about the notebook.

zoq avatar Jul 28 '21 23:07 zoq

785x42000 Dataset Loaded Train Dataset Size : (784, 42000) Validation Dataset Size : (784, 0) Training ... I am not sure why....I did build mlpack from master...maybe I will create a new build and test it...

swaingotnochill avatar Aug 04 '21 04:08 swaingotnochill

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

The generate_image.py file is incomplete[I have yet to implement what kartik proposed]. Also the code needs a bit of cleaning. Please let me know if there is any logic error.

swaingotnochill avatar Aug 09 '21 09:08 swaingotnochill

@zoq @kartikdutt18 I am preparing the final notebook, but it seems that it crashes very often. Will it be alright if we can have the model definition, and the explanation part on the notebook.

swaingotnochill avatar Aug 12 '21 07:08 swaingotnochill

@zoq @kartikdutt18 Can you review the code? See if this can merge. Later, after the model is trained, we can just push the updated output. As for the notebook, I have just added the output code. The model architecture is written in comments in the mnist_gan.cpp file. Just let me know if we want to write the same model architecture in notebook too. Also, if there is anything to add, feel free to tell.

swaingotnochill avatar Aug 19 '21 15:08 swaingotnochill

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! :+1:

mlpack-bot[bot] avatar Sep 27 '21 20:09 mlpack-bot[bot]

@swaingotnochill Is there anything else required for this PR? This addition is very nice.

shrit avatar Sep 27 '21 21:09 shrit

@swaingotnochill Is there anything else required for this PR? This addition is very nice.

The saved model is only trained for 2 epochs...We can merge this, just that we have to train the model for this which might take some days. But, the architecture seems fine for now, so shouldn't be an issue if we add this..

swaingotnochill avatar Oct 21 '21 06:10 swaingotnochill

@zoq do we merge this?

shrit avatar Nov 23 '21 01:11 shrit

I will try to port the C++ example manually to the examples repo.

shrit avatar Jul 03 '24 16:07 shrit

@geekypathak21 feel free when you have the time to port this one as well, many thanks

shrit avatar Aug 05 '24 14:08 shrit

@shrit Sure will do :+1:

geekypathak21 avatar Aug 05 '24 15:08 geekypathak21