examples icon indicating copy to clipboard operation
examples copied to clipboard

added install.R. runtime.txt, and R notebook

Open abernauer opened this issue 4 years ago • 6 comments

  1. Added the R notebook
  2. Updated the binder directory with a runtime.txt file containing the R version.
  3. Updated the binder directory with a install.R file with packages to install.

abernauer avatar Oct 21 '20 19:10 abernauer

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

  • All code should follow the style guide
  • Documentation added for any new functionality
  • Tests added for any new functionality
  • Tests that are added follow the testing guide
  • Headers and license information added to the top of any new code files
  • HISTORY.md updated if the changes are big or user-facing
  • All CI checks should be passing

Thank you again for your contributions! :+1:

mlpack-bot[bot] avatar Oct 21 '20 19:10 mlpack-bot[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

If unintentional, this works towards #97. :1st_place_medal: This is awesome, but I don't feel I can give an approval since I learned exactly enough R to marginally pass assignments where it was needed :upside_down_face:

birm avatar Oct 26 '20 20:10 birm

@birm Yes sort of unintentional. Though I had fun writing the example and would love to adapt some of the other examples for the R bindings.

abernauer avatar Oct 27 '20 14:10 abernauer

Pushed the commit addressing the comments by @zoq :smile:

abernauer avatar Oct 28 '20 18:10 abernauer

Hey @abernauer, thanks for taking the time to implement this! It looks great. I left a bunch of comments through ReviewNB; hopefully they're helpful. I do have some slight (but not serious) concern about the CF model itself; I wonder if we need to tune it with different parameters so that the movies it shows are more common. Probably the rank parameter is what would need to be tuned. Maybe worth a shot to see what happens and if the results look qualitatively better or worse? :+1:

rcurtin avatar Nov 11 '20 01:11 rcurtin

@abernauer this is nice work, but I will have to close this PR, we did a major refactoring of this repository and I would doubt that it will be easy to solve all the merge conflicts. Therefore, if you are still interested feel free to open this PR again.

shrit avatar Jul 03 '24 16:07 shrit