examples icon indicating copy to clipboard operation
examples copied to clipboard

Guidelines for adding new examples

Open Aakash-kaushik opened this issue 4 years ago • 12 comments

So this issue gives out a template or a guide that can be followed or kept in mind when writing new examples:

  • The examples should be well documented in terms that can easily be understood by people entering the field of Machine learning or have been in it for a long time.

  • Make examples simple enough so the user can basically grasp what he needs to build his own full-fledged model and don't over-complicate the examples but still try to include all library functionalities related to that example.

  • A little bit more can be written about parameters or functionalities which are implemented differently in mlpack than what the common notion is or which might confuse the user.

  • When adding the comments and writing tutorials try to mention why you followed a particular strategy in the example and maybe mention what are the implications of the strategy that you took and what are the other ways a user can proceed with the example.

  • Some examples that show things that are particularly interesting or practical can take a divergence from these guidelines and can become a bit complicated, maybe an example of such could be GANs but not limited to it.

  • And please take a look at the example that exists before and try to avoid redundant examples.

And lastly, this is just a guide, not strict rules so have fun writing examples and show your creativity. :)

Aakash-kaushik avatar Sep 28 '20 14:09 Aakash-kaushik

@Aakash-kaushik Thank you for writing this, I think we can add some points about tutorials too. It is quite straightforward to write examples. Most of the above points can be agreed on by most of us. However, it would interesting to add some points about comments and tutorials considering each example, users would like to know why we followed this pattern in writing code :+1:

shrit avatar Sep 28 '20 14:09 shrit

I think we should leave space for especially interesting or practical examples, even if they aren't especially simple.

birm avatar Sep 28 '20 14:09 birm

@Aakash-kaushik Thank you for writing this, I think we can add some points about tutorials too. It is quite straightforward to write examples. Most of the above points can be agreed on by most of us. However, it would interesting to add some points about comments and tutorials considering each example, users would like to know why we followed this pattern in writing code :+1:

I need to think about how and what to write and then i will add it.

Aakash-kaushik avatar Sep 28 '20 15:09 Aakash-kaushik

I think we should leave space for especially interesting or practical examples, even if they aren't especially simple.

Yes that is correct I will add that point too.

Aakash-kaushik avatar Sep 28 '20 15:09 Aakash-kaushik

Hey @shrit, @birm give it a look now.

Aakash-kaushik avatar Sep 28 '20 16:09 Aakash-kaushik

@Aakash-kaushik Thanks for putting this together, can you run a spell checker over the text?

zoq avatar Sep 28 '20 21:09 zoq

@Aakash-kaushik Thanks for putting this together, can you run a spell checker over the text?

Edited the issue, Take a look now.

Aakash-kaushik avatar Sep 28 '20 21:09 Aakash-kaushik

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! :+1:

mlpack-bot[bot] avatar Oct 28 '20 22:10 mlpack-bot[bot]

@rcurtin do you think we can pin this issue?

shrit avatar Oct 28 '20 23:10 shrit

Yeah! Not a bad idea. Done. :+1: Thanks @Aakash-kaushik for originally writing these up!

rcurtin avatar Oct 30 '20 22:10 rcurtin

I will add some example tutorial using mlpack. I will document the examples well understood and precise. Please assign this to me

Naidu-Saikiran avatar Mar 10 '22 08:03 Naidu-Saikiran

I will add some example tutorial using mlpack. I will document the examples well understood and precise. Please assign this to me

Hey @Saikirannaidu225, welcome and feel free to take those up and create a draft PR for those. But this issue is just a skeleton and only serves as a guideline on how things should be and not as an actual issue.

Aakash-kaushik avatar Mar 10 '22 10:03 Aakash-kaushik