benchmarks
benchmarks copied to clipboard
Including version information in the database. This file reads the config.yaml file and returns a dictionary which contains library as the key and version as the value.
@rcurtin @zoq
This is regarding Issue (#42). I need some pointers on which piece of code to look for if I want to include the information returned by the dictionary in the database.
Can one of the admins verify this patch?
Hi @Iron-Stark, sorry for the slow reply on this one. I think that what we should do instead is get the version information from libraries/package-urls.txt (we probably have to add a new column), that way when you update the package you only have to do it in one place.
All of the database code is found in util/database.py, so I think the majority of modification would go there.
From there I think there are a couple options; not sure what you think is best (@zoq, you probably have an opinion too, feel free to elaborate):
-
Change the name for the
librariestable to include the version, i.e.library_name + " " + version-->mlpack 2.2.3. Probably no other modification necessary, one would just need to update all the code that generates library names in the code. -
Add a
versionfield to thelibrariestable (seeCreateLibrariesTable()), then make sure that the version is properly handled when adding new benchmark results inNewMetricResult(),NewBootstrapResult(),UpdateMetricResult(),UpdateMetricResult(),NewResult(), andUpdateResult(), and possibly other places (I haven't done a full search).
What do you think? There are probably other ideas too.