Mike Lorbetske

Results 18 comments of Mike Lorbetske

_From @LeighF51 on June 6, 2018 7:16_ @seancpeters In the source the dockerfile can be found at the root of the service template project i.e. C:\Users\fyfieldl\source\Templates\ServiceTemplate\NetCore\NetCoreServiceTemplate - from here I...

_From @seancpeters on June 8, 2018 21:26_ @LeighF51 - I'm going to need to play with a copy of your template to figure out what's going on. Is the template...

_From @LeighF51 on June 11, 2018 9:50_ @seancpeters You can find a version of the template at https://github.com/LeighF51/ServiceTemplate Only invoking the template from VS, not using dotnet new at all

Taking a look at the nupkg generated when building the solution in the repo, it looks like the docker file is being placed at a different location than expected. To...

PR available in https://github.com/JamesNK/Newtonsoft.Json/pull/2877

@elgonzo thanks for the response. yep, the converter was just an example, not intended to be production-ready code.

~~I'll fix the build error for using nullability annotations in a non-nullable context shortly~~ done

I'm going to move these details into #806 as this makes the most sense to do as part of that work.