chm-lib icon indicating copy to clipboard operation
chm-lib copied to clipboard
verified publisher icon mlocati

Test enhancement

Open peter279k opened this issue 7 years ago • 8 comments

Changed log

  • Merge composer-travis-ci.json to composer.json.
  • Using class-based PHPUnit namespace to be compatible with latest PHPUnit versions.
  • Define multiple PHPUnit versions to support different PHP versions.

peter279k avatar Nov 13 '18 15:11 peter279k

We are missing coveralls in the new composer.json. I think we need something like what I did in https://github.com/mlocati/ip-lib/pull/21

mlocati avatar Nov 13 '18 16:11 mlocati

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4eaccfc41e62a4c31fcaf7c7e02723aca3 on peter279k:test_enhancement into bff03c063c78ff2374aa29b671a0598efe94174e on mlocati:master.

coveralls avatar Nov 13 '18 16:11 coveralls

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4eaccfc41e62a4c31fcaf7c7e02723aca3 on peter279k:test_enhancement into bff03c063c78ff2374aa29b671a0598efe94174e on mlocati:master.

coveralls avatar Nov 13 '18 16:11 coveralls

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4eaccfc41e62a4c31fcaf7c7e02723aca3 on peter279k:test_enhancement into bff03c063c78ff2374aa29b671a0598efe94174e on mlocati:master.

coveralls avatar Nov 13 '18 16:11 coveralls

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4eaccfc41e62a4c31fcaf7c7e02723aca3 on peter279k:test_enhancement into bff03c063c78ff2374aa29b671a0598efe94174e on mlocati:master.

coveralls avatar Nov 13 '18 16:11 coveralls

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4eaccfc41e62a4c31fcaf7c7e02723aca3 on peter279k:test_enhancement into bff03c063c78ff2374aa29b671a0598efe94174e on mlocati:master.

coveralls avatar Nov 13 '18 16:11 coveralls

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4eaccfc41e62a4c31fcaf7c7e02723aca3 on peter279k:test_enhancement into bff03c063c78ff2374aa29b671a0598efe94174e on mlocati:master.

coveralls avatar Nov 13 '18 16:11 coveralls

@mlocati, thank you for your comment.

I've added the "php-coveralls/php-coveralls": "^1.0" in composer.json and try to add the coveralls service back.

But it looks like the coveralls service has been broken because the code coverage percent is reduced.

It's strange because I don't do anything big changes for tests...

peter279k avatar Nov 13 '18 16:11 peter279k