savitzky-golay icon indicating copy to clipboard operation
savitzky-golay copied to clipboard

reconsider default values

Open targos opened this issue 9 years ago • 3 comments

Current default values are not intuitive. The SG function is first a smoothing algorithm and should behave like this if the derivative option is not entered. See https://github.com/mljs/savitzky-golay/issues/15

targos avatar Nov 19 '15 07:11 targos

@targos , you are right, it's a smoothing algorithm, but the usual application is for derivatives

maasencioh avatar Nov 19 '15 14:11 maasencioh

@mljs/collaborators what should we do with this?, I think that the default value should be the first derivative.

maasencioh avatar Feb 19 '16 22:02 maasencioh

The default value should be 0. In principle it is intended to smooth the function, but S-G extended it to approach derivatives as well. I don't think there is a preferred derivative order. It will depend on the application.

andcastillo avatar Feb 19 '16 22:02 andcastillo