libsvm icon indicating copy to clipboard operation
libsvm copied to clipboard

refactor: cleanup

Open wadjih-bencheikh18 opened this issue 2 years ago • 6 comments

wadjih-bencheikh18 avatar Mar 01 '22 19:03 wadjih-bencheikh18

do you know why the nodejs workflow isn't running in this PR?

No idea. I verified that actions are enabled for the repo.

targos avatar Mar 02 '22 12:03 targos

Btw I would be surprised if everything still works without changes given the huge amount of major dependency upgrades.

targos avatar Mar 02 '22 12:03 targos

No idea. I verified that actions are enabled for the repo.

Going to check what's the problem

wadjih-bencheikh18 avatar Mar 02 '22 12:03 wadjih-bencheikh18

Yes I think the dependencies should not be bumped in this one. There is an ongoing branch which updates some of the deps, so there will be conflicts

https://github.com/mljs/libsvm/tree/upgrade-deps

I'm working on this on my free time but I think that branch can be merged once I find a few hours to finish it.

stropitek avatar Mar 02 '22 12:03 stropitek

Also the tests rely on code that is generated by emscripten, so no chance this will work without a build step first

stropitek avatar Mar 02 '22 12:03 stropitek

I think we should hold off on this PR. Finish your branch first, then work on this again (emscripten will have to be installed in the workflow somehow)

targos avatar Mar 02 '22 12:03 targos