mljar-supervised icon indicating copy to clipboard operation
mljar-supervised copied to clipboard

Published 20 hours ago • verified publisher icon mljar

Make BaseAlgorithm inherit from ABC

Open diogosilva30 opened this issue 4 years ago • 2 comments

Since BaseAlgorithm is an abstract class, it should inherit from ABC, and the methods that must be implemented in child classes should be decorated with @abstractmethod. This could potentially prevent coding errors to fly under the radar, as it enforces child classes to implement methods. Thoughts on this @pplonski ?

diogosilva30 avatar Sep 02 '20 01:09 diogosilva30

@spamz23 you are right.

There are two more places that will need better code and refactoring: preprocessing and ensembling. Have you looked at them?

What do you think about this AutoML package, do you think it can be more popular than existing ML packages, for example, scikit-learn?

pplonski avatar Sep 02 '20 08:09 pplonski

No I haven't. Do you to assign me this task?

diogosilva30 avatar Sep 02 '20 15:09 diogosilva30